Call go-kit/log instead of go-kit/kit/log to fix spurious debug logs#1094
Merged
joe-elliott merged 5 commits intomainfrom Nov 2, 2021
Merged
Call go-kit/log instead of go-kit/kit/log to fix spurious debug logs#1094joe-elliott merged 5 commits intomainfrom
joe-elliott merged 5 commits intomainfrom
Conversation
bboreham
requested review from
annanay25,
dgzlopes,
joe-elliott,
mapno,
mdisibio and
yvrhdn
as code owners
This version of go-kit/kit/log is just a pass-through to go-kit/log. Also updates a number of dependencies, including the following: * github.com/aws/aws-sdk-go from v1.38.68 to v1.40.45 * github.com/go-kit/log from v0.1.0 to v0.2.0 * github.com/json-iterator/go from v1.1.11 to v1.1.12 * github.com/hashicorp/go-hclog from v0.14.0 to v0.16.2 * github.com/klauspost/compress from v1.13.5 to v1.13.6 * golang.org/x/net from ad29c8ab022f to 978cfadd31cf None of these changes looks material to Tempo. After update, ran `go mod tidy -go=1.16 && go mod tidy -go=1.17`. This makes `make vendor-check` pass; I don't think it actually changes what gets linked.
They are identical - the first is a pass-through to the latter - but the linter generates errors due to go-kit/kit/log being marked deprecated.
bboreham
force-pushed
the
update-go-kit
branch
from
fe916c0 to
8e228aa
Compare
bboreham
changed the title
mdisibio
approved these changes
Nov 2, 2021
Contributor
mdisibio
left a comment
mdisibio
left a comment
There was a problem hiding this comment.
Thanks for the update. Basic testing is looking good (log level filtering, s3 backend)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because some upstream code is now using
go-kit/loginstead ofgo-kit/kit/log, some debug logging from that code will pass through the level filter.go-kit/kitv0.12.0 addresses this by makinggo-kit/kit/logjust a pass-through togo-kit/log, but we need to update all the calls in Tempo otherwise golangci-lint fails because the passthrough is also marked deprecated.Updates a number of dependencies, including the following:
None of these changes looks material to Tempo.
github.com/klauspost/compressupdates from v1.13.5 to v1.13.6, advertising some performance improvements.Checklist
CHANGELOG.mdupdated